linux-ext4 - Re: [PATCH] ext4: Remove EXT4_STATE_DIOREAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180322155314.GK2852@thunk.org>
Date:   Thu, 22 Mar 2018 11:53:14 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     Nikolay Borisov <nborisov@...e.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Remove EXT4_STATE_DIOREAD_LOCK flag

On Tue, Feb 20, 2018 at 02:07:44PM +0100, Jan Kara wrote:
> On Tue 20-02-18 12:20:05, Nikolay Borisov wrote:
> > Commit 16c54688592c ("ext4: Allow parallel DIO reads") reworked the way
> > locking happens around parallel dio reads. This resulted in obviating
> > the need for EXT4_STATE_DIOREAD_LOCK flag and accompanying logic.
> > Currently this amounts to dead code so let's remove it. No functional
> > changes
> > 
> > Signed-off-by: Nikolay Borisov <nborisov@...e.com>
> 
> Very good point. The patch looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Applied, thanks.  Apologies for the delay in processing ext4 patches.

	 	  	    	    	  - Ted