linux-ext4 - Re: [PATCH 5/5] e2fsck: adjust quota counters when clearing orphaned inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180325185935.GA4804@magnolia>
Date:   Sun, 25 Mar 2018 11:59:35 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 5/5] e2fsck: adjust quota counters when clearing orphaned
 inodes

On Sun, Mar 25, 2018 at 01:44:29AM -0400, Theodore Y. Ts'o wrote:
> On Fri, Mar 23, 2018 at 06:58:07PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@...cle.com>
> > 
> > If e2fsck encounters a filesystem that supports internal quotas, it is
> > responsible for adjusting the quota counters if it decides to clear any
> > orphaned inodes.  Therefore, we must read the quota files, adjust the
> > counters, and write the quota files back out when we are done.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> 
> Applying this patch stand-alone causes test failures in
> f_orphan_extents_inode and f_orphan_indirect_inode.
> 
> Could you take a look, please?

Aha, one of the sizeof expressions to e2fsck_read_inode_full got FUBAR'd
in the truncate-and-reread-inode case.  Will resend.

--D

> 
> 					- Ted