linux-ext4 - Re: [PATCH 1/3] ext4: show more binary mount options in procfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180330045722.GK3790@thunk.org>
Date:   Fri, 30 Mar 2018 00:57:22 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Tyson Nottingham <tgnottingham@...il.com>
Cc:     linux-ext4@...r.kernel.org, adilger.kernel@...ger.ca
Subject: Re: [PATCH 1/3] ext4: show more binary mount options in procfs

On Wed, Mar 07, 2018 at 09:53:36PM -0800, Tyson Nottingham wrote:
> Previously, /proc/fs/ext4/<dev>/options would only show binary options
> if they were set (1 in the options bit mask). E.g. it would show "grpid"
> if it was set, but it would not show "nogrpid" if grpid was not set.
> 
> This seems sensible, but when an option is absent from the file, it can
> be hard for the unfamiliar to know what is being used. E.g. if there
> isn't a (no)grpid entry, nogrpid is in effect. But if there isn't a
> (no)auto_da_alloc entry, auto_da_alloc is in effect. If there isn't a
> (minixdf|bsddf) entry, it turns out bsddf is in effect. It all depends
> on how the option is implemented.
> 
> It's clearer to be explicit, so print the corresponding option
> regardless of whether it means a 1 or a 0 in the bit mask.
> 
> Note that options which do not have an explicit disable option aren't
> indicated as being disabled even with this change (e.g. dax).
> 
> Signed-off-by: Tyson Nottingham <tgnottingham@...il.com>

Applied, thanks.

						- Ted