linux-ext4 - Re: [PATCH 3/3] ext4: don't show data=<mode> option if defaulted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180330050114.GM3790@thunk.org>
Date:   Fri, 30 Mar 2018 01:01:14 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Tyson Nottingham <tgnottingham@...il.com>
Cc:     linux-ext4@...r.kernel.org, adilger.kernel@...ger.ca
Subject: Re: [PATCH 3/3] ext4: don't show data=<mode> option if defaulted

On Wed, Mar 07, 2018 at 09:53:38PM -0800, Tyson Nottingham wrote:
> Previously, mount -l would show data=<mode> even if the ext4 default
> journaling mode was being used. Change this to be consistent with the
> rest of the options.
> 
> Ext4 already did the right thing when the journaling mode being used
> matched the one specified in the superblock's default mount options. The
> reason it failed to do the right thing for the ext4 defaults is that,
> when set, they were never included in sbi->s_def_mount_opt (unlike the
> superblock's defaults, which were).
> 
> Signed-off-by: Tyson Nottingham <tgnottingham@...il.com>

Applied, thanks.

					- Ted