linux-ext4 - Re: e2fsprogs-1.44.1 self-tests f_bigalloc_badinode and f_bigalloc_orphan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180331204748.GA18893@thunk.org>
Date:   Sat, 31 Mar 2018 16:47:48 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Somchai Smythe <buraphalinuxserver@...il.com>
Cc:     linux-ext4@...r.kernel.org, harshads@...gle.com
Subject: Re: e2fsprogs-1.44.1 self-tests f_bigalloc_badinode and
 f_bigalloc_orphan_list fail for me

On Wed, Mar 28, 2018 at 09:20:59AM +0700, Somchai Smythe wrote:
> (2nd try to send this since apparently attachments don't go through;
> if it's a duplicate, sorry about that)
> 
> The new e2fsprogs-1.44.1 release has two failures of self-tests for me:
> 
> f_bigalloc_badinode
> f_bigalloc_orphan_list
> ...
> Are these tests passing for everyone else (make check)?  What other
> information do I need to send (if any)?

Hi Somchai,

These test were passing for me, but when I took a closer look at the
test scripts, I found the problem.  The following patch should fix
things for you (and will be in the next release of e2fsprogs).

       	       	    	       	   - Ted

commit 79284d3992a11bf6f39fd2c0c606d038b99f4774
Author: Theodore Ts'o <tytso@....edu>
Date:   Sat Mar 31 16:38:48 2018 -0400

    tests: use mke2fs and debugfs from the build tree
    
    The tests f_bigalloc_badinode and f_bigalloc_orphan_list were not
    using the version of mke2fs and debugfs from the build tree, and if
    mke2fs and debugfs are not in the user's PATH, these tests would fail.
    Fix this.
    
    Reported-by: Somchai Smythe <buraphalinuxserver@...il.com>
    Signed-off-by: Theodore Ts'o <tytso@....edu>

diff --git a/tests/f_bigalloc_badinode/script b/tests/f_bigalloc_badinode/script
index 9113e9c87..e58910f29 100644
--- a/tests/f_bigalloc_badinode/script
+++ b/tests/f_bigalloc_badinode/script
@@ -6,8 +6,8 @@ TEST_DATA="$test_name.tmp"
 dd if=$TEST_BITS of=$TEST_DATA bs=4k count=2 seek=1> /dev/null 2>&1
 
 touch $TMPFILE
-mke2fs -Fq -t ext4 -O bigalloc -C 16384 $TMPFILE 1M > /dev/null 2>&1
-debugfs -w $TMPFILE << EOF > /dev/null 2>&1
+$MKE2FS -Fq -t ext4 -O bigalloc -C 16384 $TMPFILE 1M > /dev/null 2>&1
+$DEBUGFS -w $TMPFILE << EOF > /dev/null 2>&1
 write $TEST_DATA testfile
 set_inode_field testfile i_mode 0120000
 quit
diff --git a/tests/f_bigalloc_orphan_list/script b/tests/f_bigalloc_orphan_list/script
index 1508bf126..af9d75302 100644
--- a/tests/f_bigalloc_orphan_list/script
+++ b/tests/f_bigalloc_orphan_list/script
@@ -6,8 +6,8 @@ TEST_DATA="$test_name.tmp"
 dd if=$TEST_BITS of=$TEST_DATA bs=28k count=1 > /dev/null 2>&1
 
 touch $TMPFILE
-mke2fs -Fq -t ext4 -O bigalloc $TMPFILE 1M > /dev/null 2>&1
-debugfs -w $TMPFILE << EOF > /dev/null 2>&1
+$MKE2FS -Fq -t ext4 -O bigalloc $TMPFILE 1M > /dev/null 2>&1
+$DEBUGFS -w $TMPFILE << EOF > /dev/null 2>&1
 write $TEST_DATA testfile
 set_inode_field testfile links_count 0
 set_inode_field testfile bmap[0] 0