linux-ext4 - Re: [PATCH] Ext4: Set BBITMAP_CORRUPT_BIT when failing to read the allocation bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180416170125.mco7n23o4mzumeby@US-160370MP2.local>
Date:   Mon, 16 Apr 2018 10:01:27 -0700
From:   Liu Bo <bo.liu@...ux.alibaba.com>
To:     Wang Shilong <wshilong@....com>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        "tytso@....edu" <tytso@....edu>
Subject: Re: [PATCH] Ext4: Set BBITMAP_CORRUPT_BIT when failing to read the
 allocation bitmap

On Mon, Apr 16, 2018 at 01:37:23AM +0000, Wang Shilong wrote:
>   Yup, that patch have been used in Lustre deployment from RHEL6 and RHEL7 for years.
> I think what Liu Bo tried to fix is a BUG.
>   If you agreed, I could send our improved patch for bitmap corruptions handling  to upstream.

The patch looks good to me, but needs to cover ext4_wait_block_bitmap
as well with ext4_corrupted_block_group().

thanks,
-liubo