linux-ext4 - Re: [PATCH] ext4 : fix comments in ext4_swap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180419145028.44fqs4wy5ofhvn5z@quack2.suse.cz>
Date:   Thu, 19 Apr 2018 16:50:28 +0200
From:   Jan Kara <jack@...e.cz>
To:     "zhenwei.pi" <zhenwei.pi@...runcloud.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4 : fix comments in ext4_swap_extents

On Mon 19-03-18 16:34:09, zhenwei.pi wrote:
> "mark_unwritten" in comment and "unwritten" in variable
> argument lists is mismatch.
> 
> Signed-off-by: zhenwei.pi <zhenwei.pi@...runcloud.com>

This seems to have fallen through cracks. The patch looks good to me. Ted,
can you please merge it? Thanks!

								Honza

> ---
>  fs/ext4/extents.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 054416e..2fc4227 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -5751,7 +5751,7 @@ int ext4_insert_range(struct inode *inode, loff_t offset, loff_t len)
>   * @lblk1:	Start block for first inode
>   * @lblk2:	Start block for second inode
>   * @count:	Number of blocks to swap
> - * @mark_unwritten: Mark second inode's extents as unwritten after swap
> + * @unwritten: Mark second inode's extents as unwritten after swap
>   * @erp:	Pointer to save error value
>   *
>   * This helper routine does exactly what is promise "swap extents". All other
> -- 
> 2.7.4
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR