linux-ext4 - Re: [PATCH] ext4: set h_journal if there is a failure starting a reserved handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180419124121.GE23194@thunk.org>
Date:   Thu, 19 Apr 2018 08:41:21 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>,
        Jan Kara <jack@...e.cz>, stable@...nel.org
Subject: Re: [PATCH] ext4: set h_journal if there is a failure starting a
 reserved handle

On Wed, Apr 18, 2018 at 10:07:43AM -0600, Andreas Dilger wrote:
> 
> > On Apr 18, 2018, at 9:49 AM, Theodore Ts'o <tytso@....edu> wrote:
> > 
> > If ext4 tries to start a reserved handle via
> > jbd2_journal_start_reserved(), and the journal has been aborted, this
> > can result in a NULL pointer dereference.  This is because the fields
> > h_journal and h_transaction in the handle structure share the same
> > meory, via a union, so jbd2_journal_start_reserved() will clear
> 
> (typo) s/meory/memory/

Thanks, fixed.

						- Ted