linux-ext4 - Re: [PATCH v2 1/3] vfs: add the sb_start_intwrite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180423140228.6kjv2e4vwr5emiu5@quack2.suse.cz>
Date:   Mon, 23 Apr 2018 16:02:28 +0200
From:   Jan Kara <jack@...e.cz>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     Theodore Tso <tytso@....edu>, Jan Kara <jack@...e.cz>,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2 1/3] vfs: add the sb_start_intwrite_trylock() helper

On Sun 22-04-18 18:10:57, Amir Goldstein wrote:
> Needed by ext4 to test frozen fs before updating s_last_mounted.
> 
> Signed-off-by: Amir Goldstein <amir73il@...il.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  include/linux/fs.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 760d8da1b6c7..cac41f1bad05 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1597,6 +1597,11 @@ static inline void sb_start_intwrite(struct super_block *sb)
>  	__sb_start_write(sb, SB_FREEZE_FS, true);
>  }
>  
> +static inline int sb_start_intwrite_trylock(struct super_block *sb)
> +{
> +	return __sb_start_write(sb, SB_FREEZE_FS, false);
> +}
> +
>  
>  extern bool inode_owner_or_capable(const struct inode *inode);
>  
> -- 
> 2.7.4
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR