linux-ext4 - Re: [PATCH 04/40] proc: introduce proc_create_seq{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Apr 2018 14:19:25 +0100
From:   David Howells <dhowells@...hat.com>
To:     Christoph Hellwig <hch@....de>
Cc:     dhowells@...hat.com, Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        linux-rtc@...r.kernel.org, Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-ide@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        jfs-discussion@...ts.sourceforge.net,
        linux-afs@...ts.infradead.org, linux-acpi@...r.kernel.org,
        netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
        Jiri Slaby <jslaby@...e.com>, linux-ext4@...r.kernel.org,
        Alexey Dobriyan <adobriyan@...il.com>,
        megaraidlinux.pdl@...adcom.com, drbd-dev@...ts.linbit.com
Subject: Re: [PATCH 04/40] proc: introduce proc_create_seq{,_data}

Christoph Hellwig <hch@....de> wrote:

> +
> +struct proc_dir_entry *proc_create_seq_data(const char *name, umode_t mode,
> +		struct proc_dir_entry *parent, const struct seq_operations *ops,
> +		void *data)
> +{
> ...
> +EXPORT_SYMBOL(proc_create_seq_data);

Please add documentation comments to exported functions when you add them.

David