linux-ext4 - Re: [PATCH 0/2] bigalloc + delalloc reservation leak fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANQeFDAOGMO-YXPkQ2M5dU3ApXJ2UTs3HV5VvAd0OOcuOwY3fA@mail.gmail.com>
Date:   Sat, 12 May 2018 13:56:58 +0800
From:   Liu Bo <obuil.liubo@...il.com>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     Liu Bo <bo.liu@...ux.alibaba.com>, linux-ext4@...r.kernel.org,
        Eric Whitney <enwlinux@...il.com>
Subject: Re: [PATCH 0/2] bigalloc + delalloc reservation leak fixes

On Mon, May 7, 2018 at 10:52 PM, Theodore Y. Ts'o <tytso@....edu> wrote:
> On Mon, May 07, 2018 at 10:18:10PM +0800, Liu Bo wrote:
>> These two fixes are to address the reservation leak problem we've
>> found when using bigalloc with delalloc.
>>
>> A specific fstests case is available at
>> https://patchwork.kernel.org/patch/10384221/
>>
>> Liu Bo (2):
>>   Ext4: bigalloc: fix overreservation on quota accounting
>>   Ext4: bigalloc: do not reserve space for delalloc extents if there is
>>     an available cluster
>
> Hi Liu,
>
> Eric has been working in this area as well, and has been working on a
> series of patches.  (This had been discussed on the weekly ext4
> teleconference calls; if this is something you would be interested in
> joining, please contact me via e-mail privately.)
>
> My understanding is that his patch series is a bit more complex, since
> he was working on a number of cleanups at the same time.  Eric, could
> you send out your patch series, even if they aren't fully polished, so
> we can see how much overlap there is between your work and Liu Bo's?
>

Can we first review and queue these two fixes to address the bug?

As you can see from the test case I sent, it's so easy to hit the bug
and it'd kept bothering everyone who is using bigalloc even in the
simplest way.

thanks,
liubo