linux-ext4 - Re: [PATCH] ext4: update mtime in ext4_punch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180513233900.GH14763@thunk.org>
Date:   Sun, 13 May 2018 19:39:00 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ext4: update mtime in ext4_punch_hole even if no blocks
 are released

On Tue, Apr 24, 2018 at 03:07:51PM +0200, Lukas Czerner wrote:
> Currently in ext4_punch_hole we're going to skip the mtime update if
> there are no actual blocks to release. However we've actually modified
> the file by zeroing the partial block so the mtime should be updated.
> 
> Moreover the sync and datasync handling is skipped as well, which is
> also wrong. Fix it.
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> Reported-by: Joe Habermann <joe.habermann@...ntum.com>
> Cc: <stable@...r.kernel.org>

Thanks, applied.

						- Ted