linux-ext4 - Re: [PATCH] ext4: Fix hole length detection in ext4_ind_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180513195042.GE14763@thunk.org>
Date:   Sun, 13 May 2018 15:50:42 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org, Jeff Mahoney <jeffm@...e.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix hole length detection in ext4_ind_map_blocks()

On Thu, May 10, 2018 at 05:38:51PM +0200, Jan Kara wrote:
> When ext4_ind_map_blocks() computes a length of a hole, it doesn't count
> with the fact that mapped offset may be somewhere in the middle of the
> completely empty subtree. In such case it will return too large length
> of the hole which then results in lseek(SEEK_DATA) to end up returning
> an incorrect offset beyond the end of the hole.
> 
> Fix the problem by correctly taking offset within a subtree into account
> when computing a length of a hole.
> 
> Fixes: facab4d9711e7aa3532cb82643803e8f1b9518e8
> CC: stable@...r.kernel.org
> Reported-by: Jeff Mahoney <jeffm@...e.com>
> Signed-off-by: Jan Kara <jack@...e.cz>

Applied, thanks.

					- Ted