lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 15 May 2018 16:12:33 +0200
From:   Christoph Hellwig <>
To:     "Eric W. Biederman" <>
Cc:     Christoph Hellwig <>,
        Andrew Morton <>,
        Alexander Viro <>,
        Alexey Dobriyan <>,
        Greg Kroah-Hartman <>,
        Jiri Slaby <>,
        Alessandro Zummo <>,
        Alexandre Belloni <>,,,,,,,,,,,,,
Subject: Re: [PATCH 34/40] atm: simplify procfs code

On Sat, May 05, 2018 at 07:51:18AM -0500, Eric W. Biederman wrote:
> Christoph Hellwig <> writes:
> > Use remove_proc_subtree to remove the whole subtree on cleanup, and
> > unwind the registration loop into individual calls.  Switch to use
> > proc_create_seq where applicable.
> Can you please explain why you are removing the error handling when
> you are unwinding the registration loop?

Because there is no point in handling these errors.  The code work
perfectly fine without procfs, or without given proc files and the
removal works just fine if they don't exist either.  This is a very
common patter in various parts of the kernel already.

I'll document it better in the changelog.

Powered by blists - more mailing lists