linux-ext4 - Re: [PATCH 4/5] ext4: use ext4_warning() for sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <79C501BF-FD10-4E3D-9BF1-8862ED3F70C5@dilger.ca>
Date:   Mon, 4 Jun 2018 12:11:21 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Wang Shilong <wangshilong1991@...il.com>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>,
        Shuichi Ihara <sihara@....com>, Wang Shilong <wshilong@....com>
Subject: Re: [PATCH 4/5] ext4: use ext4_warning() for sb_getblk failure

On May 29, 2018, at 5:45 AM, Wang Shilong <wangshilong1991@...il.com> wrote:
> 
> From: Wang Shilong <wshilong@....com>
> 
> out of memory should not be considered as critical
> errors, replace ext4_warnig() instead of ext4_error()
> for it.

(typo) "ext4_warning()" can be fixed at landing time.

> Signed-off-by: Wang Shilong <wshilong@....com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> fs/ext4/balloc.c | 6 +++---
> fs/ext4/ialloc.c | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
> index e3feeae..5fe63ff 100644
> --- a/fs/ext4/balloc.c
> +++ b/fs/ext4/balloc.c
> @@ -428,9 +428,9 @@ struct buffer_head *
> 	}
> 	bh = sb_getblk(sb, bitmap_blk);
> 	if (unlikely(!bh)) {
> -		ext4_error(sb, "Cannot get buffer for block bitmap - "
> -			   "block_group = %u, block_bitmap = %llu",
> -			   block_group, bitmap_blk);
> +		ext4_warning(sb, "Cannot get buffer for block bitmap - "
> +			     "block_group = %u, block_bitmap = %llu",
> +			     block_group, bitmap_blk);
> 		return ERR_PTR(-ENOMEM);
> 	}
> 
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index b7f7299..787b613 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -135,9 +135,9 @@ static int ext4_validate_inode_bitmap(struct super_block *sb,
> 	}
> 	bh = sb_getblk(sb, bitmap_blk);
> 	if (unlikely(!bh)) {
> -		ext4_error(sb, "Cannot read inode bitmap - "
> -			    "block_group = %u, inode_bitmap = %llu",
> -			    block_group, bitmap_blk);
> +		ext4_warning(sb, "Cannot read inode bitmap - "
> +			     "block_group = %u, inode_bitmap = %llu",
> +			     block_group, bitmap_blk);
> 		return ERR_PTR(-ENOMEM);
> 	}
> 	if (bitmap_uptodate(bh))
> --
> 1.8.3.1
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)