linux-ext4 - Re: [PATCH 08/10] debugfs: Allow fixing superblock errors in catastrophic mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0B986D60-079C-4435-806F-B0AB791D8281@dilger.ca>
Date:   Sun, 3 Jun 2018 22:52:33 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Jan Kara <jack@...e.cz>
Cc:     Ted Tso <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 08/10] debugfs: Allow fixing superblock errors in
 catastrophic mode

On May 30, 2018, at 6:51 AM, Jan Kara <jack@...e.cz> wrote:
> 
> Open filesystem with EXT2_FLAG_IGNORE_SB_ERRORS flag in catastrophic
> mode so that superblock errors can be fixed in debugfs.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> debugfs/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index b1842443aa8e..51e3783bfa86 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -160,7 +160,7 @@ static void open_filesystem(char *device, int open_flags, blk64_t superblock,
> 	}
> 
> 	if (catastrophic)
> -		open_flags |= EXT2_FLAG_SKIP_MMP;
> +		open_flags |= EXT2_FLAG_SKIP_MMP | EXT2_FLAG_IGNORE_SB_ERRORS;
> 
> 	if (undo_file) {
> 		retval = debugfs_setup_tdb(device, undo_file, &io_ptr);
> --
> 2.13.6
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)