linux-ext4 - Re: [PATCH] ext4: Reset error code in ext4_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1313AA4D-12EF-4E42-8D7A-331DDFD76633@dilger.ca>
Date:   Fri, 8 Jun 2018 15:30:31 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Eric Sandeen <sandeen@...hat.com>
Cc:     "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        anatoly.trosinenko@...dex.com
Subject: Re: [PATCH] ext4: Reset error code in ext4_find_entry in fallback

On Jun 6, 2018, at 12:49 PM, Eric Sandeen <sandeen@...hat.com> wrote:
> 
> When ext4_find_entry() falls back to "searching the old fashioned
> way" due to a corrupt dx dir, it needs to reset the error code
> to NULL so that the nonstandard ERR_BAD_DX_DIR code isn't returned
> to userspace.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=199947
> 
> Reported-by: Anatoly Trosinenko <anatoly.trosinenko@...dex.com>
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index b1f21e3a0763..559b2b9d392a 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -1398,6 +1400,7 @@ static struct buffer_head * ext4_find_entry (struct inode *dir,
> 			goto cleanup_and_exit;
> 		dxtrace(printk(KERN_DEBUG "ext4_find_entry: dx failed, "
> 			       "falling back\n"));
> +		ret = NULL;
> 	}
> 	nblocks = dir->i_size >> EXT4_BLOCK_SIZE_BITS(sb);
> 	if (!nblocks) {


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)