linux-ext4 - Re: [PATCH 05/10] e2fsck: Allow to fix some superblock corruptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180619151002.GI6931@thunk.org>
Date:   Tue, 19 Jun 2018 11:10:02 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 05/10] e2fsck: Allow to fix some superblock corruptions

On Tue, Jun 12, 2018 at 11:53:23AM +0200, Jan Kara wrote:
> Add a flag to ext2fs_open() which allows to open a filesystem even if
> superblock is somewhat inconsistent. Use this flag from e2fsck as a last
> resort to try to fix the superblok.
> 
> Currently, the flag does nothing. We'll relax checks in ext2fs_open()
> once e2fsck is able to handle corresponding corruption gracefully.
> 
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> Signed-off-by: Jan Kara <jack@...e.cz>

This patch, alas, causes test failures:

	f_crashdisk f_detect_xfs j_ext_dumpe2fs 

I strongly commend running "make check" when making changes to
e2fsprogs.

						- Ted