linux-ext4 - Re: [PATCH] ext4: check orig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3371bc52-ba69-f90f-e809-5d9a53141d6e@gmx.com>
Date:   Wed, 20 Jun 2018 11:00:37 +0800
From:   cgxu519 <cgxu519@....com>
To:     tytso@....edu, adilger.kernel@...ger.ca
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: check orig_data in remount

Hi Ted, Andreas

Could you have a look at this trivial patch?

Thanks.

On 06/06/2018 04:26 PM, Chengguang Xu wrote:
> Currently duplicate data to orig_data in ext4_remount()
> but there is lack of check for duplication result.
> This patch adds proper check for it.
>
> Signed-off-by: Chengguang Xu<cgxu519@....com>
> ---
>   fs/ext4/super.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 00fe75a71c4b..cba245460a9c 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5014,6 +5014,9 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data)
>   #endif
>   	char *orig_data = kstrdup(data, GFP_KERNEL);
>   
> +	if (data && !orig_data)
> +		return -ENOMEM;
> +
>   	/* Store the original options */
>   	old_sb_flags = sb->s_flags;
>   	old_opts.s_mount_opt = sbi->s_mount_opt;