linux-ext4 - Re: [PATCH] ext4: check orig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2069ab32-dbd9-823c-7f06-dae03c2ca25f@gmx.com>
Date:   Wed, 20 Jun 2018 13:40:59 +0800
From:   cgxu519 <cgxu519@....com>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Theodore Ts'o <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: check orig_data in remount


On 06/20/2018 12:31 PM, Andreas Dilger wrote:
>> On Jun 6, 2018, at 2:26 AM, Chengguang Xu <cgxu519@....com> wrote:
>>
>> Currently duplicate data to orig_data in ext4_remount()
>> but there is lack of check for duplication result.
>> This patch adds proper check for it.
>>
>> Signed-off-by: Chengguang Xu <cgxu519@....com>
> Thank you for the patch.  I think it looks correct, but I was
> initially confused by the commit message.  I think something
> like the following would be more clear:
>
>      There is no check for allocation failure when duplicating
>      "orig_data" in ext4_remount().  Check for failure and
>      return an error in this case.
>
>
> While I don't think it is (currently) possible for a one-page
> allocation to fail (always true because of copy_mount_options()
> used in ksys_mount()), I prefer to always check for allocation
> failures in case this ever changes in the future, or if there
> is allocation fault injection or other fuzzing turned on.
>
> In any case, you can add:
>
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>

Thanks for your review, I'll modify changelog in v2.

Thanks,
Chengguang.