[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180620080000.hjg3tbvuc5izhw3y@quack2.suse.cz>
Date: Wed, 20 Jun 2018 10:00:00 +0200
From: Jan Kara <jack@...e.cz>
To: "Theodore Y. Ts'o" <tytso@....edu>
Cc: Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 05/10] e2fsck: Allow to fix some superblock corruptions
On Tue 19-06-18 11:10:02, Theodore Y. Ts'o wrote:
> On Tue, Jun 12, 2018 at 11:53:23AM +0200, Jan Kara wrote:
> > Add a flag to ext2fs_open() which allows to open a filesystem even if
> > superblock is somewhat inconsistent. Use this flag from e2fsck as a last
> > resort to try to fix the superblok.
> >
> > Currently, the flag does nothing. We'll relax checks in ext2fs_open()
> > once e2fsck is able to handle corresponding corruption gracefully.
> >
> > Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> > Signed-off-by: Jan Kara <jack@...e.cz>
>
> This patch, alas, causes test failures:
>
> f_crashdisk f_detect_xfs j_ext_dumpe2fs
>
> I strongly commend running "make check" when making changes to
> e2fsprogs.
Ah, sorry, forgot about that. Will do it next time.
Honza
--
Jan Kara <jack@...e.com>
SUSE Labs, CR
Powered by blists - more mailing lists