linux-ext4 - Re: [PATCH 05/10] ext2fs: annotate superblock/inode offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180622165802.GH3498@thunk.org>
Date:   Fri, 22 Jun 2018 12:58:02 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 05/10] ext2fs: annotate superblock/inode offsets

On Tue, May 01, 2018 at 10:26:01PM -0600, Andreas Dilger wrote:
> Add byte offsets for the fields in ext2_super_block and ext2_inode
> for convenience when debugging on-disk structures.
> 
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>

Thanks, applied.  By the way, the way I'pve normally get the byte
offsets for the superblock is to use ./lib/ext2fs/tst_super_size.

At the moment tst_super_size prints the offsets in decimal, and your
patch adds offsets in hex.  Right now, debugfs's hexdump and idump
commands prints its offsets in octal, because of the precedence of od.

What do people think?  Should we standardize on some base in how we
display and print offsets and hexdumps?

					- Ted