linux-ext4 - Re: [PATCH 09/10] e2fsck: set dir_nlink feature if large dir exists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180622222107.GL3498@thunk.org>
Date:   Fri, 22 Jun 2018 18:21:07 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 09/10] e2fsck: set dir_nlink feature if large dir exists

On Tue, May 01, 2018 at 10:26:05PM -0600, Andreas Dilger wrote:
> If there is a directory with more than EXT2_LINK_MAX (65000)
> subdirectories, but the DIR_NLINK feature is not set in the
> superblock, the feature should be set before continuing on
> to change the on-disk directory link count to 1.
> 
> While most filesystems should have DIR_NLINK set (it was set
> by default for all ext4 filesystems, and all kernels between
> 2.6.23 and 4.12 automatically set it if the directory link
> count grew too large), it is possible that this flag is lost
> due to disk corruption or for an upgraded filesystem.  We no
> longer want kernels to automatically enable features.
> 
> Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=196405
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>

Thanks, applied.

					- Ted