linux-ext4 - Re: [PATCH] tests: Force inode table initialization for all tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180628174946.GA25030@thunk.org>
Date:   Thu, 28 Jun 2018 13:49:46 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] tests: Force inode table initialization for all tests

On Thu, Jun 28, 2018 at 02:00:42PM +0200, Lukas Czerner wrote:
> Currently, depending on whether or not the ext4 module is loaded into
> kernel and what version it is the inode table will, or will not be
> initialized when the file system is resized. This is fine in practice,
> however in out test suite we need more deterministic behavior.
> 
> Set RESIZE2FS_FORCE_ITABLE_INIT environment variable globally for all
> tests so that the code doing the inode table initialization is
> exercised as well and to make resize2fs output more deterministic.
> 
> Change the expected output of r_move_itable_nostride and
> r_move_itable_realloc tests that previously failed only when the ext4
> module was not laded into kernel.
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>

This was fixed slightly differently in my tree.  I used a different
default than your patch, but it uses basically the same approach.

	     	  	     	- Ted

commit 74430052bc5b3fffff3330f054849ca829fe24dc (origin/maint)
Author: Theodore Ts'o <tytso@....edu>
Date:   Tue Jun 26 09:59:19 2018 -0400

    tests: explicitly force resize2fs's use of lazy (or not)
    
    Resize2fs will not enable lazy_itable if the kernel apparently does
    not support that feature.  This will cause spurious test failures when
    the tests are running on such a system (or where sysfs is not
    mounted).
    
    So for the purposes of the regression test we need to force the use of
    lazy_itable so that the results conform to expected golden output.
    
    Signed-off-by: Theodore Ts'o <tytso@....edu>