linux-ext4 - Re: [PATCH 0/1] iomap: Direct I/O for inline data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHc6FU5yrGCZ+aVxeo9tBxmmQRKs02r2MwE_JMQxQpaZ61PU-w@mail.gmail.com>
Date:   Fri, 29 Jun 2018 13:01:48 +0200
From:   Andreas Gruenbacher <agruenba@...hat.com>
To:     Christoph Hellwig <hch@....de>
Cc:     cluster-devel <cluster-devel@...hat.com>,
        linux-ext4 <linux-ext4@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 0/1] iomap: Direct I/O for inline data

On 29 June 2018 at 10:43, Christoph Hellwig <hch@....de> wrote:
>> A possible fix is to change the alignment check in iomap_dio_actor as follows:
>>
>> -       if ((pos | length | align) & ((1 << blkbits) - 1))
>> +       if ((pos | align) & ((1 << blkbits) - 1))
>> +               return -EINVAL;
>> +       if (length & ((1 << blkbits) - 1) &&
>> +           pos + length != iomap->offset + iomap->length)
>>                 return -EINVAL;
>>
>> Moving the alignment check from iomap_dio_actor to iomap_dio_rw isn't
>> that easy because iomap->bdev isn't known there.
>
> Just make the check conditional on iomap->type != IOMAP_INLINE
> as alignment checks on inline data don't make much sense.

Yeah, probably.

Thanks,
Andreas