lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 11 Jul 2018 13:01:41 -0400
From:   "Theodore Y. Ts'o" <>
To:     Gabriel Krisman Bertazi <>
Subject: Re: [PATCH 01/20] nls: Wrap uni2char/char2uni callers

On Tue, Jul 03, 2018 at 01:06:41PM -0400, Gabriel Krisman Bertazi wrote:
> Generated with the following coccinele script:
> <smpl>
> @@
> expression A, B, C, D;
> @@
> (
> - A->uni2char(B, C, D)
> + nls_uni2char(A, B, C, D)
> |
> - A->char2uni(B, C, D)
> + nls_char2uni(A, B, C, D)
> )
> </smpl>
> Signed-off-by: Gabriel Krisman Bertazi <>

It would be really helpful if in addition to describe *what* the
commit does, to also describe *why*.  What is the purpose of adding an
inline function to wrap the indirection?  This is especially important
since there is no real maintainer and no real development for NLS (and
hence not a lot of people who have a lot of expertise with the code).
So having some explanation in the NLS commits in this series would be
very useful.

						- Ted

Powered by blists - more mailing lists