linux-ext4 - Re: [PATCH 01/20] nls: Wrap uni2char/char2uni callers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87va9lo6h3.fsf@collabora.co.uk>
Date:   Wed, 11 Jul 2018 16:36:08 -0400
From:   Gabriel Krisman Bertazi <krisman@...labora.co.uk>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     linux-ext4@...r.kernel.org, darrick.wong@...cle.com,
        kernel@...labora.com
Subject: Re: [PATCH 01/20] nls: Wrap uni2char/char2uni callers

"Theodore Y. Ts'o" <tytso@....edu> writes:

> On Tue, Jul 03, 2018 at 01:06:41PM -0400, Gabriel Krisman Bertazi wrote:
>> Generated with the following coccinele script:
>> 
>> <smpl>
>> 
>> @@
>> expression A, B, C, D;
>> @@
>> (
>> - A->uni2char(B, C, D)
>> + nls_uni2char(A, B, C, D)
>> |
>> - A->char2uni(B, C, D)
>> + nls_char2uni(A, B, C, D)
>> )
>> 
>> </smpl>
>> 
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.co.uk>
>
> It would be really helpful if in addition to describe *what* the
> commit does, to also describe *why*.  What is the purpose of adding an
> inline function to wrap the indirection?  This is especially important
> since there is no real maintainer and no real development for NLS (and
> hence not a lot of people who have a lot of expertise with the code).
> So having some explanation in the NLS commits in this series would be
> very useful.
>

Hi,

Sorry about that.  I will fix the commit messages in the next iteration
to add the explanation below.

For char2uni/uni2char it was simply meant to simplify the output of
patch 3, which was generated by coccinelle to make it touch less things
at once.  For other fields, in particular charset2lower/charset2upper,
it will allow a future patch to drop the tables of ascii and utf8n, for
instance, and do the conversion algorithmically, which will simplify the
nls code.

-- 
Gabriel Krisman Bertazi