linux-ext4 - Re: [PATCH 17/20] ext4: Include encoding information in the superblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180712020245.GE9955@thunk.org>
Date:   Wed, 11 Jul 2018 22:02:45 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Gabriel Krisman Bertazi <krisman@...labora.co.uk>
Cc:     linux-ext4@...r.kernel.org, darrick.wong@...cle.com,
        kernel@...labora.com
Subject: Re: [PATCH 17/20] ext4: Include encoding information in the
 superblock

As the kbuild bot has already reported, you've added an unconditional
dependency on the NLS subsystem, which is not always compiled in.
What we need to do is to add #ifdef's on CONFIG_NLS, and only support
file systems with encoding if the kernel is compiled with CONFIG_NLS.

One thought --- do we really need to use CONFIG_NLS if the encoding is
ASCII?  If some use case (and Android may be one) only is interested
in supporting case-folding for ASCII, and they don't want to have the
overhead of compiling in the NLS subsystem, for ASCII couldn't use
just use strcasecmp() for its comparison function?

The normalization for ASCII is the identify function, so it's kind of
pointless to support ASCII if we ony have case-folding support and not
normalization for now, right?

					- Ted