linux-ext4 - Re: [PATCH] ext4: fix warning message to output correct type.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1DAA5A30-4DCD-44B9-84AC-8D6D62D07ABC@dilger.ca>
Date:   Fri, 13 Jul 2018 22:17:11 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Junichi Uekawa <uekawa@...gle.com>
Cc:     "Theodore Y. Ts'o" <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: fix warning message to output correct type.


> On Jul 13, 2018, at 3:15 AM, Junichi Uekawa <uekawa@...gle.com> wrote:
> 
> Output the warning message before we clobber type and be -1 all the time.
> The error message would now be
> 
> [    1.519791] EXT4-fs warning (device vdb): ext4_enable_quotas:5402:
> Failed to enable quota tracking (type=0, err=-3). Please run e2fsck to fix.
> 
> Signed-off-by: Junichi Uekawa <uekawa@...gle.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> fs/ext4/super.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index ba2396a7bd04..1b90f619663c 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5670,13 +5670,13 @@ static int ext4_enable_quotas(struct super_block *sb)
> 				DQUOT_USAGE_ENABLED |
> 				(quota_mopt[type] ? DQUOT_LIMITS_ENABLED : 0));
> 			if (err) {
> -				for (type--; type >= 0; type--)
> -					dquot_quota_off(sb, type);
> -
> 				ext4_warning(sb,
> 					"Failed to enable quota tracking "
> 					"(type=%d, err=%d). Please run "
> 					"e2fsck to fix.", type, err);
> +				for (type--; type >= 0; type--)
> +					dquot_quota_off(sb, type);
> +
> 				return err;
> 			}
> 		}
> --
> 2.18.0.203.gfac676dfb9-goog
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)