linux-ext4 - Re: [PATCH v2 1/6] ext4: sysfs: print ext4_super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180722172320.GB6685@thunk.org>
Date:   Sun, 22 Jul 2018 13:23:20 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     adilger.kernel@...ger.ca, jack@...e.cz, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, sirmy15@...il.com,
        stable@...r.kernel.org, tgnottingham@...il.com,
        y2038@...ts.linaro.org
Subject: Re: [PATCH v2 1/6] ext4: sysfs: print ext4_super_block fields as
 little-endian

On Wed, Jul 11, 2018 at 11:14:09AM +0200, Arnd Bergmann wrote:
> While working on extended rand for last_error/first_error timestamps,
> I noticed that the endianess is wrong, we access the little-endian
> fields in struct ext4_super_block as native-endian when we print them.
> 
> This adds a special case in ext4_attr_show() and ext4_attr_store()
> to byteswap the superblock fields if needed.
> 
> In older kernels, this code was part of super.c, it got moved to sysfs.c
> in linux-4.4.
> 
> Cc: stable@...r.kernel.org
> Fixes: 52c198c6820f ("ext4: add sysfs entry showing whether the fs contains errors")
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.

				- Ted