linux-ext4 - Re: [PATCH] e2fsprogs: fix compile error and warnings for old gcc versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180722190131.GH6685@thunk.org>
Date:   Sun, 22 Jul 2018 15:01:31 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Li Dongyang <dongyangli@....com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fsprogs: fix compile error and warnings for old gcc
 versions

On Fri, Jul 13, 2018 at 06:42:48PM -0600, Li Dongyang wrote:
> -Wimplicit-fallthrough option was added in gcc7 and
> -Wpedantic was added in gcc4.8, while #pragma GCC diagnostic
> support was not available until gcc4.6
> 
> We got following warnings:
> ../lib/ext2fs/fiemap.h:35: warning: expected [error|warning|ignored] after ‘#pragma GCC diagnostic’
> ../lib/ext2fs/fiemap.h:36: warning: unknown option after ‘#pragma GCC diagnostic’ kind
> ../lib/ext2fs/fiemap.h:38: warning: expected [error|warning|ignored] after ‘#pragma GCC diagnostic’
> 
> and error:
> filefrag.c: In function ‘main’:
> filefrag.c:577: error: #pragma GCC diagnostic not allowed inside functions
> filefrag.c:578: error: #pragma GCC diagnostic not allowed inside functions
> filefrag.c:595: error: #pragma GCC diagnostic not allowed inside functions
> 
> when compiling latest e2fsprogs with a gcc older than 4.6
> e.g. on CentOS 6.9
> 
> Signed-off-by: Li Dongyang <dongyangli@....com>

Applied, thanks.

					- Ted