linux-ext4 - Re: [PATCH resend 2/5] ext4: wrap error handling and corrupted bitmaps setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180730013453.GL21725@thunk.org>
Date:   Sun, 29 Jul 2018 21:34:53 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Wang Shilong <wangshilong1991@...il.com>
Cc:     linux-ext4@...r.kernel.org, andreas.dilger@...el.com,
        sihara@....com, wshilong@....com
Subject: Re: [PATCH resend 2/5] ext4: wrap error handling and corrupted
 bitmaps setting

On Tue, May 29, 2018 at 08:45:14PM +0900, Wang Shilong wrote:
> From: Wang Shilong <wshilong@....com>
> 
> Cleanup to handle ext4 error codes together with
> bitmaps corrupted bits setting.
> 
> Signed-off-by: Wang Shilong <wshilong@....com>
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> ---
>  fs/ext4/balloc.c  | 28 +++++++++++++++-------------
>  fs/ext4/ext4.h    | 35 ++++++++++++++++++++++++-----------
>  fs/ext4/ialloc.c  | 37 +++++++++++++++++++------------------
>  fs/ext4/mballoc.c | 20 ++++++++------------
>  fs/ext4/super.c   | 11 +++++++----
>  5 files changed, 73 insertions(+), 58 deletions(-)

This change makes the code longer and it's **really** not clear why it
is a "cleanup".  This is an example of explaining *why* is often far
more important than the *what*.

					- Ted