linux-ext4 - Re: [PATCH] ext4: check for NUL characters in extended attribute's name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180731033501.GA27268@thunk.org>
Date:   Mon, 30 Jul 2018 23:35:01 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Cc:     wen.xu@...ech.edu
Subject: Re: [PATCH] ext4: check for NUL characters in extended attribute's
 name

On Mon, Jul 30, 2018 at 11:30:30PM -0400, Theodore Ts'o wrote:
> Extended attribute names are defined to be NUL-terminated, so the name
> must not contain a NUL character.  This is important because there are
> places when remove extended attribute, the code uses strlen to
> determine the length of the entry.  That should probably be fixed at
> some point, but code is currently really messy, so the simplest fix
> for now is to simply validate that the extended attributes are sane.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=200623

Oops, sorry, wrong bug.  That should have read:

    https://bugzilla.kernel.org/show_bug.cgi?id=200401

I'll fix this in my tree.

				- Ted