linux-ext4 - Re: [PATCH] ext4/mballoc: Remove unneeded variable "err"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Aug 2018 17:24:26 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4/mballoc: Remove unneeded variable "err"

On Sat, Aug 04, 2018 at 07:04:56PM +0800, zhong jiang wrote:
> The err is not used after initalization. So just remove the variable.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

I'll apply this patch, but how did you generate the diff?  The
function name here is all wrong:

> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 8b24d3d..e29fce2 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -3801,7 +3801,6 @@ static int ext4_mb_new_preallocation(struct ext4_allocation_context *ac)
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^

The lines in question are from ext4_mb_release_inode_pa(), *not*
ext4_mb_new_preallocation().  So when I inspected the patch visually,
my first reaction was, "there's no way this patch would apply".

But then I looked at the C code changed by the patch, and I was
surprised to see that it applied correctly in a completely different
function, and when I regenerated the patch, the line numbers matched
yours --- so the only thing "wrong" in your patch is the function name.

So that raises the question --- how did you create the diff in this
patch?  What version of git?  And what version of the kernel?

Regards,

					- Ted