linux-ext4 - Re: [PATCH] ext4: Fix build error when DX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180809081008.qurvgawjd4uipox5@localhost.localdomain>
Date:   Thu, 9 Aug 2018 10:10:08 +0200
From:   Lukas Czerner <lczerner@...hat.com>
To:     Gabriel Krisman Bertazi <krisman@...labora.co.uk>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH] ext4: Fix build error when DX_DEBUG is defined

On Wed, Aug 08, 2018 at 02:20:43PM -0400, Gabriel Krisman Bertazi wrote:
> Enabling DX_DEBUG triggers the build error below.  The info pointer
> should be accessed via the dxroot pointer.
> 
> linux/fs/ext4/namei.c:2264:12: error: ‘info’
> undeclared (first use in this function); did you mean ‘insl’?
> 	   	  info->indirect_levels));

Looks good,

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Thanks!
-Lukas

> 
> Fixes: e08ac99fa2a2 ("ext4: add largedir feature")
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.co.uk>
> ---
>  fs/ext4/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index 116ff68c5bd4..35b635b4df58 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -2261,7 +2261,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
>  			dxroot->info.indirect_levels += 1;
>  			dxtrace(printk(KERN_DEBUG
>  				       "Creating %d level index...\n",
> -				       info->indirect_levels));
> +				       dxroot->info.indirect_levels));
>  			err = ext4_handle_dirty_dx_node(handle, dir, frame->bh);
>  			if (err)
>  				goto journal_error;
> -- 
> 2.18.0
>