linux-ext4 - Re: [PATCH] scrub: use MKDIR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180821172851.GB11884@gmail.com>
Date:   Tue, 21 Aug 2018 10:28:51 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] scrub: use MKDIR_P instead of MKINSTALLDIRS

On Tue, Aug 21, 2018 at 10:25:32AM -0700, Eric Biggers wrote:
> On Tue, Aug 21, 2018 at 09:51:59AM +0200, Lukas Czerner wrote:
> > MKINSTALLDIRS variable is not defined in scrub/Makefile for
> > creating the directories. Use MKDIR_P instead.
> > 
> > Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> > ---
> >  scrub/Makefile.in | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> > 
> > diff --git a/scrub/Makefile.in b/scrub/Makefile.in
> > index f58331de..fc8cbcfd 100644
> > --- a/scrub/Makefile.in
> > +++ b/scrub/Makefile.in
> > @@ -85,24 +85,24 @@ e2scrub_all_cron: e2scrub_all_cron.in
> >  	$(Q) $(SUBSTITUTE_UPTIME) $< $@
> >  
> >  installdirs-udev:
> > -	$(E) "	MKINSTALLDIRS $(UDEV_RULES_DIR)"
> > -	$(Q) $(MKINSTALLDIRS) $(DESTDIR)$(UDEV_RULES_DIR)
> > +	$(E) "	$(MKDIR_P) $(DESTDIR)$(UDEV_RULES_DIR)"
> > +	$(Q) $(MKDIR_P) $(DESTDIR)$(UDEV_RULES_DIR)
> 
> Nit: the other Makefile.in's in e2fsprogs have "MKDIR_P" in the $(E) echo line,
> not "$(MKDIR_P)".
>

Also this patch adds $(DESTDIR) to the echo line here, but it's not in any of
the other ones.

- Eric