linux-ext4 - Re: [PATCH] libext2fs: add verity flag to EXT2_LIB_FEATURE_RO_COMPAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180821034934.GB16002@thunk.org>
Date:   Mon, 20 Aug 2018 23:49:34 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] libext2fs: add verity flag to
 EXT2_LIB_FEATURE_RO_COMPAT_SUPP

On Mon, Aug 20, 2018 at 05:15:52PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> The new ro_compat filesystem feature flag for fs-verity was added to
> EXT2_FEATURE_RO_COMPAT_SUPP, but that's not actually used by e2fsprogs
> itself.  So contrary to the v1.44.4 release notes, 'mke2fs -O verity'
> doesn't actually work, nor does e2fsck allow the filesystem to have the
> verity feature.  Fix it by adding the flag to the correct place
> (EXT2_LIB_FEATURE_RO_COMPAT_SUPP) too.
> 
> Fixes: faae7aa00df0 ("Reserve codepoints for the fsverity feature.")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Double oops!  Thanks, applied.

					- Ted