linux-ext4 - Re: [PATCH v2] fs: Convert return type int to vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180830163352.5a96cc721ce069bed95fdbe8@linux-foundation.org>
Date:   Thu, 30 Aug 2018 16:33:52 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     konishi.ryusuke@....ntt.co.jp, viro@...iv.linux.org.uk,
        tytso@....edu, adilger.kernel@...ger.ca, axboe@...nel.dk,
        darrick.wong@...cle.com, ebiggers@...gle.com, pombredanne@...b.com,
        agruenba@...hat.com, gregkh@...uxfoundation.org,
        kemi.wang@...el.com, willy@...radead.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-ext4@...r.kernel.org, linux-nilfs@...r.kernel.org
Subject: Re: [PATCH v2] fs: Convert return type int to vm_fault_t

On Thu, 30 Aug 2018 22:55:47 +0530 Souptick Joarder <jrdr.linux@...il.com> wrote:

> Return type for fault handlers  in ext4 and nilfs are
> changed to use vm_fault_t.
> 
> Return type of block_page_mkwrite() is changed from
> int to vm_fault_t. The function signature of
> block_page_mkwrite() is changed to add one new parameter
> int *err. This will provide a way for caller functions
> to get error value along with return value and use it
> further.
> 
> Return type of block_page_mkwrite_return() is also changed
> to use new vm_fault_t type.
> --- a/fs/nilfs2/file.c
> +++ b/fs/nilfs2/file.c
> @@ -51,13 +51,14 @@ int nilfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
>  	return err;
>  }
>  
> -static int nilfs_page_mkwrite(struct vm_fault *vmf)
> +static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf)

nilfs_page_mkwrite() already has return type vm_fault_t in Linus's
kernel, due to the now-merged
fs-nilfs2-adding-new-return-type-vm_fault_t.patch.  Looks like a simple
fix.

I'm beginning to feel vm_fault_t exhaustion.  Please remind me what
benefit we're going to get out of all this churn?

> 
> ...
>