lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20180903090332.GE10027@quack2.suse.cz> Date: Mon, 3 Sep 2018 11:03:32 +0200 From: Jan Kara <jack@...e.cz> To: Chengguang Xu <cgxu519@....com> Cc: jack@...e.com, tytso@....edu, adilger.kernel@...ger.ca, jaegeuk@...nel.org, yuchao0@...wei.com, shaggy@...nel.org, hubcap@...ibond.com, martin@...ibond.com, devel@...ts.orangefs.org, linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, jfs-discussion@...ts.sourceforge.net Subject: Re: [PATCH v2 1/5] ext2: cache NULL when both default_acl and acl are NULL On Fri 31-08-18 22:33:48, Chengguang Xu wrote: > default_acl and acl of newly created inode will be initiated > as ACL_NOT_CACHED in vfs function inode_init_always() and later > will be updated by calling xxx_init_acl() in specific filesystems. > Howerver, when default_acl and acl are NULL then they keep the value > of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl > in this case. > > Signed-off-by: Chengguang Xu <cgxu519@....com> Thanks! I'll take this patch (with slight changelog update) to my tree. Honza > --- > v1->v2: > - Coding style change. > > fs/ext2/acl.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/ext2/acl.c b/fs/ext2/acl.c > index 224c04abb2e5..cf4c77f8dd08 100644 > --- a/fs/ext2/acl.c > +++ b/fs/ext2/acl.c > @@ -256,11 +256,15 @@ ext2_init_acl(struct inode *inode, struct inode *dir) > if (default_acl) { > error = __ext2_set_acl(inode, default_acl, ACL_TYPE_DEFAULT); > posix_acl_release(default_acl); > + } else { > + inode->i_default_acl = NULL; > } > if (acl) { > if (!error) > error = __ext2_set_acl(inode, acl, ACL_TYPE_ACCESS); > posix_acl_release(acl); > + } else { > + inode->i_acl = NULL; > } > return error; > } > -- > 2.17.1 > > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists