lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAFqt6zY41OnT6F8F7vyUEJcc_RPoF3mALAOS7CUMUvQv8GdG0w@mail.gmail.com> Date: Mon, 3 Sep 2018 17:28:46 +0530 From: Souptick Joarder <jrdr.linux@...il.com> To: Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp> Cc: Andrew Morton <akpm@...ux-foundation.org>, Al Viro <viro@...iv.linux.org.uk>, "Theodore Ts'o" <tytso@....edu>, adilger.kernel@...ger.ca, Jens Axboe <axboe@...nel.dk>, "Darrick J. Wong" <darrick.wong@...cle.com>, Eric Biggers <ebiggers@...gle.com>, Philippe Ombredanne <pombredanne@...b.com>, Andreas Gruenbacher <agruenba@...hat.com>, Greg KH <gregkh@...uxfoundation.org>, kemi.wang@...el.com, Matthew Wilcox <willy@...radead.org>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-nilfs <linux-nilfs@...r.kernel.org> Subject: Re: [PATCH v2] fs: Convert return type int to vm_fault_t On Mon, Sep 3, 2018 at 7:43 AM Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp> wrote: > > Hi Souptick, > > On Thu, 30 Aug 2018 16:33:52 -0700, Andrew Morton wrote: > > On Thu, 30 Aug 2018 22:55:47 +0530 Souptick Joarder wrote: > > > >> Return type for fault handlers in ext4 and nilfs are > >> changed to use vm_fault_t. > >> > >> Return type of block_page_mkwrite() is changed from > >> int to vm_fault_t. The function signature of > >> block_page_mkwrite() is changed to add one new parameter > >> int *err. This will provide a way for caller functions > >> to get error value along with return value and use it > >> further. > >> > >> Return type of block_page_mkwrite_return() is also changed > >> to use new vm_fault_t type. > >> --- a/fs/nilfs2/file.c > >> +++ b/fs/nilfs2/file.c > >> @@ -51,13 +51,14 @@ int nilfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync) > >> return err; > >> } > >> > >> -static int nilfs_page_mkwrite(struct vm_fault *vmf) > >> +static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf) > > > > nilfs_page_mkwrite() already has return type vm_fault_t in Linus's > > kernel, due to the now-merged > > fs-nilfs2-adding-new-return-type-vm_fault_t.patch. Looks like a simple > > fix. > > In the first patch in this thread, this return type change was > excluded correctly for nilfs_page_mkwrite() though the changelog was > inaccurate in that sense. > > Please confirm your base point of the revised patch. > Ryusuku, Base point of revised patch is to address your comment by removing err = 0. Nothing else was suppose to there in v2. But unfortunately I mixed up my local branches and created v2 against old branch which leads to confusion of v1 -> v2 delta changes. Sorry for creating more confusions. > > > > > I'm beginning to feel vm_fault_t exhaustion. Please remind me what > > benefit we're going to get out of all this churn? > > > >> > >> ... > >>
Powered by blists - more mailing lists