lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Sep 2018 14:11:08 -0400 From: Mike Marshall <hubcap@...ibond.com> To: cgxu519@....com Cc: jack@...e.com, "Theodore Ts'o" <tytso@....edu>, adilger.kernel@...ger.ca, jaegeuk@...nel.org, yuchao0@...wei.com, shaggy@...nel.org, Martin Brandenburg <martin@...ibond.com>, devel@...ts.orangefs.org, LKML <linux-kernel@...r.kernel.org>, Ext4 Developers List <linux-ext4@...r.kernel.org>, linux-f2fs-devel@...ts.sourceforge.net, jfs-discussion@...ts.sourceforge.net, Mike Marshall <hubcap@...ibond.com> Subject: Re: [PATCH v2 5/5] orangefs: cache NULL when both default_acl and acl are NULL Thanks... I've added your patch to 4.19-rc2, run it through xfstests, and added it to my linux-next tree... -Mike On Fri, Aug 31, 2018 at 10:35 AM Chengguang Xu <cgxu519@....com> wrote: > > default_acl and acl of newly created inode will be initiated > as ACL_NOT_CACHED in vfs function inode_init_always() and later > will be updated by calling xxx_init_acl() in specific filesystems. > Howerver, when default_acl and acl are NULL then they keep the value > of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl > in this case. > > Signed-off-by: Chengguang Xu <cgxu519@....com> > --- > v1->v2: > - Coding style change. > > fs/orangefs/acl.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/orangefs/acl.c b/fs/orangefs/acl.c > index 10587413b20e..72d2ff17d27b 100644 > --- a/fs/orangefs/acl.c > +++ b/fs/orangefs/acl.c > @@ -167,12 +167,16 @@ int orangefs_init_acl(struct inode *inode, struct inode *dir) > error = __orangefs_set_acl(inode, default_acl, > ACL_TYPE_DEFAULT); > posix_acl_release(default_acl); > + } else { > + inode->i_default_acl = NULL; > } > > if (acl) { > if (!error) > error = __orangefs_set_acl(inode, acl, ACL_TYPE_ACCESS); > posix_acl_release(acl); > + } else { > + inode->i_acl = NULL; > } > > /* If mode of the inode was changed, then do a forcible ->setattr */ > -- > 2.17.1 >
Powered by blists - more mailing lists