lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <acdda52b-02a2-52e9-4e96-2fa67ddc29a7@kernel.org> Date: Mon, 10 Sep 2018 22:45:38 +0800 From: Chao Yu <chao@...nel.org> To: Wang Shilong <wangshilong1991@...il.com>, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net Cc: adilger@...ger.ca, wshilong@....com, dchinner@...hat.com Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: fix setattr project check upon fssetxattr ioctl On 2018/9/9 17:15, Wang Shilong wrote: > From: Wang Shilong <wangshilong1991@...il.com> > > Currently, project quota could be changed by fssetxattr > ioctl, and existed permission check inode_owner_or_capable() > is obviously not enough, just think that common users could > change project id of file, that could make users to > break project quota easily. > > This patch try to follow same regular of xfs project > quota: > > "Project Quota ID state is only allowed to change from > within the init namespace. Enforce that restriction only > if we are trying to change the quota ID state. > Everything else is allowed in user namespaces." > > Besides that, check and set project id'state should > be an atomic operation, protect whole operation with > inode lock. > > Signed-off-by: Wang Shilong <wshilong@....com> It looks good to me, thanks for the patch, Shilong. :) Reviewed-by: Chao Yu <yuchao0@...wei.com> Thanks,
Powered by blists - more mailing lists