lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <19388d015c54202ee3d1e8526677ccdf7d46cd02.camel@hpe.com> Date: Tue, 11 Sep 2018 18:11:39 +0000 From: "Kani, Toshi" <toshi.kani@....com> To: "dan.j.williams@...el.com" <dan.j.williams@...el.com> CC: "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>, "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>, "jack@...e.cz" <jack@...e.cz>, "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "tytso@....edu" <tytso@....edu> Subject: Re: [PATCH 1/2] ext4, dax: update dax check to skip journal inode On Tue, 2018-09-11 at 10:59 -0700, Dan Williams wrote: > On Tue, Sep 11, 2018 at 8:42 AM, Toshi Kani <toshi.kani@....com> wrote: > > Ext4 mount path calls ext4_iget() to obtain the journal inode. This > > inode does not support DAX, and 'ext4_da_aops' needs to be set. It > > currently works for the DAX mount case because ext4_iget() always set > > 'ext4_da_aops' to any regular files. > > > > ext4_fill_super > > ext4_load_journal > > ext4_get_journal_inode > > ext4_iget > > > > In preparation to fix ext4_iget() to set 'ext4_dax_aops' for DAX files, > > update ext4_should_use_dax() to return false for the journal inode. > > > > Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086 > > Just a minor format recommendation: > > Fixes: 5f0663bb4a64 ("ext4, dax: introduce ext4_dax_aops") > Cc: <stable@...r.kernel.org> Will do. > > This looks good to me. > > Reviewed-by: Dan Williams <dan.j.williams@...el.com> Thanks! -Toshi
Powered by blists - more mailing lists