linux-ext4 - Re: [PATCH] ext4: initialize retries variable in ext4_da_write_inline_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Sep 2018 17:54:48 +0200
From:   Jan Kara <jack@...e.cz>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org, Ted Tso <tytso@....edu>
Subject: Re: [PATCH] ext4: initialize retries variable in
 ext4_da_write_inline_data_begin()

On Mon 13-08-18 15:34:59, Lukas Czerner wrote:
> Variable retries is not initialized in ext4_da_write_inline_data_begin()
> which can lead to nondeterministic number of retries in case we hit
> ENOSPC. Initialize retries to zero as we do everywhere else.
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> Fixes: bc0ca9df3b2a ("ext4: retry allocation when inline->extent conversion failed")
> Cc: stable@...nel.org
> ---
>  fs/ext4/inline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ted, this seems to have fallen through the cracks...

								Honza

> 
> diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
> index 3543fe80a3c4..1b13fa5c9d6e 100644
> --- a/fs/ext4/inline.c
> +++ b/fs/ext4/inline.c
> @@ -863,7 +863,7 @@ int ext4_da_write_inline_data_begin(struct address_space *mapping,
>  	handle_t *handle;
>  	struct page *page;
>  	struct ext4_iloc iloc;
> -	int retries;
> +	int retries = 0;
>  
>  	ret = ext4_get_inode_loc(inode, &iloc);
>  	if (ret)
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR