linux-ext4 - e2fsprogs v1.44.4 build failure with musl libc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87ftyd41zm.fsf@tkos.co.il>
Date:   Thu, 13 Sep 2018 22:43:41 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     Theodore Ts'o <tytso@....edu>
Cc:     linux-ext4@...r.kernel.org, Li Dongyang <dongyangli@....com>
Subject: e2fsprogs v1.44.4 build failure with musl libc

Hi Ted,

Commit fddc423dc6353 (Fix compile error and warnings for old gcc
versions) introduced usage of __GNUC_PREREQ. musl libc does not provide
this macro. So build with musl is broken:

In file included from ../../lib/ext2fs/ext2fs.h:97:0,
                 from feature.c:20:
../../lib/ext2fs/hashmap.h:20:19: error: missing binary operator before token "("
 #if __GNUC_PREREQ (4, 8)
                   ^
../../lib/ext2fs/hashmap.h:25:19: error: missing binary operator before token "("
 #if __GNUC_PREREQ (4, 8)
                   ^

Not sure what is the right fix. I could not find a suitable place for a
local __GNUC_PREREQ definition. Open coding __GNUC_PREREQ everywhere is
quite ugly.

Any other idea?

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -