linux-ext4 - Re: [PATCH] ext4: don't mark mmp buffer head dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180915211215.GB8652@thunk.org>
Date:   Sat, 15 Sep 2018 17:12:15 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Li Dongyang <dongyangli@....com>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: don't mark mmp buffer head dirty

On Sun, Sep 09, 2018 at 10:57:35PM -0600, Andreas Dilger wrote:
> On Sep 9, 2018, at 12:30 AM, Li Dongyang <dongyangli@....com> wrote:
> > 
> > Marking mmp bh dirty before writing it will make writeback
> > pick up mmp block later and submit a write, we don't want the
> > duplicate write as kmmpd thread should have full control of
> > reading and writing the mmp block.
> > Another reason is we will also have random I/O error on
> > the writeback request when blk integrity is enabled, because
> > kmmpd could modify the content of the mmp block(e.g. setting
> > new seq and time) while the mmp block is under I/O requested
> > by writeback.
> > 
> > Signed-off-by: Li Dongyang <dongyangli@....com>
> > Cc: Andreas Dilger <adilger@...ger.ca>
> 
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>

Thanks, applied.

				- Ted