linux-ext4 - Re: [PATCH] ext4: initialize retries variable in ext4_da_write_inline_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181003012437.GA18521@thunk.org>
Date:   Tue, 2 Oct 2018 21:24:37 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] ext4: initialize retries variable in
 ext4_da_write_inline_data_begin()

On Mon, Aug 13, 2018 at 03:34:59PM +0200, Lukas Czerner wrote:
> Variable retries is not initialized in ext4_da_write_inline_data_begin()
> which can lead to nondeterministic number of retries in case we hit
> ENOSPC. Initialize retries to zero as we do everywhere else.
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> Fixes: bc0ca9df3b2a ("ext4: retry allocation when inline->extent conversion failed")
> Cc: stable@...nel.org

Applied, thanks.

					- Ted