linux-ext4 - Re: [PATCH] ext4: fix EXT4_IOC_SWAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181003145406.GA2835@thunk.org>
Date:   Wed, 3 Oct 2018 10:54:06 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: fix EXT4_IOC_SWAP_BOOT

On Wed, Oct 03, 2018 at 05:55:20AM -0700, Christoph Hellwig wrote:
> On Tue, Oct 02, 2018 at 07:38:08PM -0400, Theodore Ts'o wrote:
> > The code EXT4_IOC_SWAP_BOOT ioctl hasn't been updated in a while, and
> > it's a bit broken with respect to more modern ext4 kernels, especially
> > metadata checksums.
> 
> Do you have any reports of anyone but sysbot actually using it?
> Maybe it is a better idea to drop it unless it also gets coverage
> in xfstests?

Adding xfstests coverage is on my todo list.  I need to clean up an
ext4-ioc.c test program so it can be added to xfstests/src, but yes, I
noticed that the lack of test coverage is what led to the code
bitrot.

There was recent discussion that perhaps Grub should use this instead
of chasing file system format changes (which was the original
intention of this patch) so I had been examining the code path looking
for potential problems anyway.  So I'd rather not drop it for now.

This will allow us to future-proof ext4 in case we ever grow support
for reflink (which I understand from Darrick has been an issue for
XFS :-).

						- Ted