linux-ext4 - Re: [PATCH 1/2] Fuse2fs: fix 'mount' entry in some cases.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181009002358.GA24099@magnolia>
Date:   Mon, 8 Oct 2018 17:23:58 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     nicholas.clark@...il.com
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] Fuse2fs: fix 'mount' entry in some cases.

On Mon, Oct 08, 2018 at 05:39:51PM -0600, nicholas.clark@...il.com wrote:
> From: Nicholas Clark <nicholas.clark@...il.com>
> 
> FUSE's parser allows command-line options to be specified before
> or after the device/image and mount-path. This commit changes the
> value of the fsname mount option to be correct even if options are
> specified before the target device/image.
> 
> Signed-off-by: Nicholas Clark <nicholas.clark@...il.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> ---
>  misc/fuse2fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/misc/fuse2fs.c b/misc/fuse2fs.c
> index 5c73895e..3214be4a 100644
> --- a/misc/fuse2fs.c
> +++ b/misc/fuse2fs.c
> @@ -3845,7 +3845,7 @@ int main(int argc, char *argv[])
>  	/* Set up default fuse parameters */
>  	snprintf(extra_args, BUFSIZ, "-okernel_cache,subtype=ext4,use_ino,"
>  		 "fsname=%s,attr_timeout=0" FUSE_PLATFORM_OPTS,
> -		 argv[1]);
> +		 fctx.device);
>  	if (fctx.no_default_opts == 0)
>  		fuse_opt_add_arg(&args, extra_args);
>  
> -- 
> 2.17.1
>