lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 Oct 2018 00:58:31 +0300 From: Vasily Averin <vvs@...tuozzo.com> To: linux-ext4@...r.kernel.org, Theodore Ts'o <tytso@....edu> Cc: Andreas Dilger <adilger.kernel@...ger.ca>, linux-kernel@...r.kernel.org, Dmitry Monakhov <dmonakhov@...il.com> Subject: [PATCH v2 08/11] ext4: lost brelse in ext4_orphan_add() iloc.bh os taken in ext4_reserve_inode_write(). If (dirty == true) it is released in ext4_mark_iloc_dirty(), however it is not released in (dirty == false) case. Fixes d745a8c20c1f ("ext4: reduce contention on s_orphan_lock") however iloc.bh count balance was broken earlier by Fixes 6e3617e579e0 ("ext4: Handle non empty on-disk orphan link") #2.6.34 cc: Dmitry Monakhov <dmonakhov@...il.com> Signed-off-by: Vasily Averin <vvs@...tuozzo.com> --- fs/ext4/namei.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 67a38532032a..d388cce72db2 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2811,7 +2811,9 @@ int ext4_orphan_add(handle_t *handle, struct inode *inode) list_del_init(&EXT4_I(inode)->i_orphan); mutex_unlock(&sbi->s_orphan_lock); } - } + } else + brelse(iloc.bh); + jbd_debug(4, "superblock will point to %lu\n", inode->i_ino); jbd_debug(4, "orphan inode %lu will point to %d\n", inode->i_ino, NEXT_ORPHAN(inode)); -- 2.17.1
Powered by blists - more mailing lists